Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F15384483: D18801.id45103.diff
Fri, Mar 14, 8:02 PM
F15340788: D18801.id45103.diff
Sun, Mar 9, 4:49 PM
F15331510: D18801.diff
Fri, Mar 7, 10:46 AM
Unknown Object (File)
Wed, Feb 26, 9:48 PM
Unknown Object (File)
Jan 22 2025, 2:43 AM
Unknown Object (File)
Jan 21 2025, 3:21 PM
Unknown Object (File)
Jan 12 2025, 6:47 AM
Unknown Object (File)
Jan 3 2025, 5:25 PM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable