Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F15581081: D18801.diff
Wed, May 7, 9:37 AM
F15567538: D18801.diff
Fri, May 2, 8:58 AM
F15565147: D18801.id.diff
Wed, Apr 30, 10:49 PM
F15564576: D18801.id45103.diff
Wed, Apr 30, 12:57 PM
F15555557: D18801.diff
Mon, Apr 28, 12:02 PM
F15527921: D18801.id45115.diff
Tue, Apr 22, 7:33 AM
F15490802: D18801.id45115.diff
Fri, Apr 11, 8:39 PM
F15454517: D18801.id45115.diff
Mar 29 2025, 6:56 PM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable