Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general

Authored by epriestley on Nov 28 2017, 6:44 PM.



See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 28 2017, 6:44 PM
epriestley requested review of this revision.Nov 28 2017, 6:46 PM
amckinley accepted this revision.Nov 28 2017, 9:20 PM
This revision is now accepted and ready to land.Nov 28 2017, 9:20 PM
This revision was automatically updated to reflect the committed changes.