Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F18868995: D18801.id.diff
Tue, Nov 4, 9:31 AM
F18854338: D18801.id.diff
Fri, Oct 31, 11:26 PM
F18848056: D18801.diff
Thu, Oct 30, 3:13 AM
F18816508: D18801.id45103.diff
Oct 21 2025, 7:24 AM
F18773043: D18801.diff
Oct 9 2025, 6:39 AM
F18705586: D18801.diff
Sep 28 2025, 12:01 PM
F18541066: D18801.id45103.diff
Sep 7 2025, 8:07 PM
F18509193: D18801.id.diff
Sep 5 2025, 3:16 AM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable