Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F17667587: D18801.diff
Sat, Jul 12, 10:27 PM
Unknown Object (File)
Mon, Jun 30, 11:16 PM
Unknown Object (File)
Sat, Jun 28, 12:42 PM
Unknown Object (File)
Jun 1 2025, 12:29 AM
Unknown Object (File)
May 31 2025, 5:20 PM
Unknown Object (File)
May 29 2025, 11:43 AM
Unknown Object (File)
May 7 2025, 9:37 AM
Unknown Object (File)
May 2 2025, 8:58 AM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable