Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F15527921: D18801.id45115.diff
Tue, Apr 22, 7:33 AM
F15490802: D18801.id45115.diff
Fri, Apr 11, 8:39 PM
F15454517: D18801.id45115.diff
Sat, Mar 29, 6:56 PM
F15453719: D18801.id45103.diff
Sat, Mar 29, 1:50 PM
F15445349: D18801.diff
Mar 27 2025, 1:33 PM
F15384483: D18801.id45103.diff
Mar 14 2025, 8:02 PM
F15340788: D18801.id45103.diff
Mar 9 2025, 4:49 PM
F15331510: D18801.diff
Mar 7 2025, 10:46 AM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable