Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F18773043: D18801.diff
Thu, Oct 9, 6:39 AM
F18705586: D18801.diff
Sun, Sep 28, 12:01 PM
F18541066: D18801.id45103.diff
Sep 7 2025, 8:07 PM
F18509193: D18801.id.diff
Sep 5 2025, 3:16 AM
F18501845: D18801.diff
Sep 4 2025, 10:00 PM
F18321485: D18801.diff
Aug 24 2025, 4:57 PM
F18091049: D18801.id45115.diff
Aug 6 2025, 6:43 PM
F18090210: D18801.id45103.diff
Aug 6 2025, 2:51 PM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18884
Build 25459: Run Core Tests
Build 25458: arc lint + arc unit