Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 4:32 AM
Unknown Object (File)
Mon, Mar 4, 9:38 PM
Unknown Object (File)
Feb 1 2024, 11:38 PM
Unknown Object (File)
Jan 9 2024, 6:50 PM
Unknown Object (File)
Dec 27 2023, 12:31 PM
Unknown Object (File)
Dec 27 2023, 12:31 PM
Unknown Object (File)
Dec 27 2023, 12:31 PM
Unknown Object (File)
Dec 22 2023, 1:07 AM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18884
Build 25459: Run Core Tests
Build 25458: arc lint + arc unit