Page MenuHomePhabricator

Remove "arc diff --only"
ClosedPublic

Authored by epriestley on Oct 27 2017, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:41 PM
Unknown Object (File)
Wed, May 1, 6:16 PM
Unknown Object (File)
Tue, Apr 30, 11:24 PM
Unknown Object (File)
Sun, Apr 28, 10:30 AM
Unknown Object (File)
Fri, Apr 26, 7:18 AM
Unknown Object (File)
Mon, Apr 22, 10:42 PM
Unknown Object (File)
Fri, Apr 19, 6:56 PM
Unknown Object (File)
Fri, Apr 19, 4:55 PM
Subscribers
None

Details

Summary

Experimental branch. Depends on D18738. Ref T2543.

To prepare for adding --draft, clean up some of the flags behaviors.

--only currently means --preview --nolint --nounit. I'm going to:

  • Remove --only.
  • Rename --preview to --only, since I think --only is a better flag for this behavior than --preview.
  • If you want the old --only, you can arc alias it to arc diff --only --nolint --nounit --browse or similar.
Test Plan

Grepped for 'only', only, etc.

Diff Detail

Repository
rARC Arcanist
Branch
draft3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18757
Build 25276: Run Core Tests
Build 25275: arc lint + arc unit