Page MenuHomePhabricator

Remove "arc diff --only"
ClosedPublic

Authored by epriestley on Oct 27 2017, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 7:46 AM
Unknown Object (File)
Wed, Mar 13, 5:09 AM
Unknown Object (File)
Feb 10 2024, 3:55 AM
Unknown Object (File)
Feb 1 2024, 11:28 PM
Unknown Object (File)
Jan 26 2024, 3:42 AM
Unknown Object (File)
Jan 25 2024, 10:18 PM
Unknown Object (File)
Dec 28 2023, 5:30 PM
Unknown Object (File)
Dec 27 2023, 12:22 PM
Subscribers
None

Details

Summary

Experimental branch. Depends on D18738. Ref T2543.

To prepare for adding --draft, clean up some of the flags behaviors.

--only currently means --preview --nolint --nounit. I'm going to:

  • Remove --only.
  • Rename --preview to --only, since I think --only is a better flag for this behavior than --preview.
  • If you want the old --only, you can arc alias it to arc diff --only --nolint --nounit --browse or similar.
Test Plan

Grepped for 'only', only, etc.

Diff Detail

Repository
rARC Arcanist
Branch
draft3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18757
Build 25276: Run Core Tests
Build 25275: arc lint + arc unit