Page MenuHomePhabricator

Return transactions from "differential.parsecommitmessage"
ClosedPublic

Authored by epriestley on Oct 27 2017, 5:02 PM.
Tags
None
Referenced Files
F13043032: D18741.id.diff
Wed, Apr 17, 2:04 PM
Unknown Object (File)
Sat, Apr 13, 5:50 AM
Unknown Object (File)
Sat, Apr 13, 5:50 AM
Unknown Object (File)
Sat, Apr 13, 2:42 AM
Unknown Object (File)
Thu, Apr 11, 9:54 AM
Unknown Object (File)
Wed, Apr 10, 1:29 AM
Unknown Object (File)
Tue, Apr 9, 4:52 PM
Unknown Object (File)
Tue, Apr 9, 12:33 AM
Subscribers
None

Details

Summary

Depends on D18740. Prepares arc to receive a --draft flag by letting us switch to "differential.revision.edit" instead of "differential.createrevision".

To "differential.revision.edit", we need a transaction list, but we can't automatically construct this list from a field map. Return the transaction list alongside the field map.

The next change uses this list (if available) to switch us to the modern API method.

Test Plan

Ran arc diff on the experiemntal branch with followup changes, got a new revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable