Page MenuHomePhabricator

Return transactions from "differential.parsecommitmessage"
ClosedPublic

Authored by epriestley on Oct 27 2017, 5:02 PM.
Tags
None
Referenced Files
F15466988: D18741.id44986.diff
Thu, Apr 3, 11:31 AM
F15456845: D18741.id44980.diff
Sun, Mar 30, 12:34 PM
F15451103: D18741.id44986.diff
Fri, Mar 28, 8:09 PM
F15450578: D18741.id44986.diff
Fri, Mar 28, 4:30 PM
F15449677: D18741.id44980.diff
Fri, Mar 28, 11:37 AM
F15444378: D18741.id.diff
Thu, Mar 27, 9:21 AM
F15440534: D18741.diff
Wed, Mar 26, 1:14 PM
F15423589: D18741.id44986.diff
Sat, Mar 22, 4:12 PM
Subscribers
None

Details

Summary

Depends on D18740. Prepares arc to receive a --draft flag by letting us switch to "differential.revision.edit" instead of "differential.createrevision".

To "differential.revision.edit", we need a transaction list, but we can't automatically construct this list from a field map. Return the transaction list alongside the field map.

The next change uses this list (if available) to switch us to the modern API method.

Test Plan

Ran arc diff on the experiemntal branch with followup changes, got a new revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable