Paths

Table of Contentst

If possible, use "differential.revision.edit" in "arc diff"
ClosedPublic
Actions

Authored by epriestley on Oct 27 2017, 5:04 PM.

Tags

None

Referenced Files

	F14015133: D18742.diff
	Sun, Nov 3, 2:15 PM

	F14012444: D18742.id44990.diff
	Fri, Nov 1, 12:33 PM

	F14012443: D18742.id44981.diff
	Fri, Nov 1, 12:33 PM

	F14012442: D18742.id.diff
	Fri, Nov 1, 12:32 PM

	F14012422: D18742.diff
	Fri, Nov 1, 12:17 PM

	F13994728: D18742.id44990.diff
	Wed, Oct 23, 8:05 AM

	F13981890: D18742.id44981.diff
	Sat, Oct 19, 7:42 PM

	F13955835: D18742.id44990.diff
	Mon, Oct 14, 3:09 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff"

Summary

Depends on D18741. Switches to "differential.revision.edit" if we get a transaction list back from parsing (added by D18740).

This will allow us to use new transactions, notably "Hold as Draft" for "--draft".

Test Plan

Ran arc diff, got a revision via differential.revision.edit.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 27 2017, 5:04 PM

Harbormaster completed remote builds in B18761: Diff 44981.Oct 27 2017, 5:05 PM

epriestley requested review of this revision.Oct 27 2017, 5:05 PM

epriestley added a child revision: D18743: Add "arc diff --draft".Oct 27 2017, 5:24 PM

amckinley accepted this revision.Oct 28 2017, 3:31 PM

This revision is now accepted and ready to land.Oct 28 2017, 3:31 PM

Closed by commit rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff" (authored by epriestley). · Explain WhyOct 30 2017, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

differential/

ArcanistDifferentialCommitMessage.php

8 lines

workflow/

ArcanistDiffWorkflow.php

51 lines

Diff 44990

View Options

src/differential/ArcanistDifferentialCommitMessage.php