Paths

Table of Contentst

If possible, use "differential.revision.edit" in "arc diff"
ClosedPublic
Actions

Authored by epriestley on Oct 27 2017, 5:04 PM.

Tags

None

Referenced Files

	F15493096: D18742.id44981.diff
	Sat, Apr 12, 9:29 PM

	F15487703: D18742.id.diff
	Thu, Apr 10, 4:21 PM

	F15482076: D18742.id44990.diff
	Wed, Apr 9, 2:40 AM

	F15466465: D18742.id.diff
	Thu, Apr 3, 5:46 AM

	F15465109: D18742.diff
	Wed, Apr 2, 2:40 PM

	F15426978: D18742.diff
	Sun, Mar 23, 12:01 PM

	F15425372: D18742.diff
	Sun, Mar 23, 4:23 AM

	Unknown Object (File)
	Feb 15 2025, 9:38 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff"

Summary

Depends on D18741. Switches to "differential.revision.edit" if we get a transaction list back from parsing (added by D18740).

This will allow us to use new transactions, notably "Hold as Draft" for "--draft".

Test Plan

Ran arc diff, got a revision via differential.revision.edit.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 27 2017, 5:04 PM

Harbormaster completed remote builds in B18761: Diff 44981.Oct 27 2017, 5:05 PM

epriestley requested review of this revision.Oct 27 2017, 5:05 PM

epriestley added a child revision: D18743: Add "arc diff --draft".Oct 27 2017, 5:24 PM

amckinley accepted this revision.Oct 28 2017, 3:31 PM

This revision is now accepted and ready to land.Oct 28 2017, 3:31 PM

Closed by commit rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff" (authored by epriestley). · Explain WhyOct 30 2017, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

differential/

ArcanistDifferentialCommitMessage.php

8 lines

workflow/

ArcanistDiffWorkflow.php

51 lines

Diff 44990

View Options

src/differential/ArcanistDifferentialCommitMessage.php