Paths

Table of Contentst

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:14 PM.

Details

Reviewers

Maniphest Tasks

T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns

Commits

rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs
rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs

Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan

Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2017, 2:14 PM

Harbormaster completed remote builds in B18597: Diff 44817.Oct 2 2017, 2:15 PM

amckinley accepted this revision.Oct 2 2017, 3:25 PM

This revision is now accepted and ready to land.Oct 2 2017, 3:25 PM

Closed by commit rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs (authored by epriestley). · Explain WhyOct 2 2017, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

link-with-angle-link-anchor.txt

5 lines

link-with-link-anchor.txt

5 lines

remarkup/

markuprule/

PhutilRemarkupHyperlinkRule.php

15 lines

Diff 44820

View Options

src/markup/engine/tests/remarkup/link-with-angle-link-anchor.txt

View Options

src/markup/engine/tests/remarkup/link-with-link-anchor.txt

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Fix an exception in the hyperlink remarkup rule for unparseable URIsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44820

src/markup/engine/__tests__/remarkup/link-with-angle-link-anchor.txt

src/markup/engine/__tests__/remarkup/link-with-link-anchor.txt

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic
Actions

Revision Contents
Changeset List

src/markup/engine/tests/remarkup/link-with-angle-link-anchor.txt

src/markup/engine/tests/remarkup/link-with-link-anchor.txt