Page MenuHomePhabricator
Differential D18666

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:14 PM.
Tags
None
Referenced Files
F18869344: D18666.diff
Tue, Nov 4, 11:16 AM
F18852816: D18666.id.diff
Fri, Oct 31, 12:17 PM
F18850639: D18666.diff
Thu, Oct 30, 6:24 PM
F18755555: D18666.diff
Oct 5 2025, 6:12 AM
F18716770: D18666.id.diff
Sep 29 2025, 12:26 PM
F18706961: D18666.diff
Sep 28 2025, 5:43 PM
F18509134: D18666.id.diff
Sep 5 2025, 3:14 AM
F18501698: D18666.diff
Sep 4 2025, 9:54 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns
Commits
rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs
rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs
Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan
  • Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository
rPHU libphutil
Branch
parse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18597
Build 25050: Run Core Tests
Build 25049: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
5 lines
5 lines
remarkup/
markuprule/
15 lines

Diff 44817

View Options

src/markup/engine/__tests__/remarkup/link-with-angle-link-anchor.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-with-link-anchor.txt

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility