Differential D18149

Fix ambiguous URI parsing in Youtube Remarkup rule
ClosedPublic
Actions

Authored by epriestley on Jun 23 2017, 2:37 PM.

Tags

None

Referenced Files

	F19072249: D18149.diff
	Nov 30 2025, 9:50 PM

	F19072211: D18149.diff
	Nov 30 2025, 9:43 PM

	F18855332: D18149.id.diff
	Nov 1 2025, 4:54 AM

	F18851814: D18149.id.diff
	Oct 31 2025, 4:26 AM

	F18848466: D18149.diff
	Oct 30 2025, 4:53 AM

	F18809526: D18149.id.diff
	Oct 19 2025, 2:48 PM

	F18805118: D18149.id43671.diff
	Oct 18 2025, 1:53 PM

	F18791250: D18149.id43668.diff
	Oct 16 2025, 8:07 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12867: Youtube remarkup rule fails to parse "ambiguous URI"

Commits

rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule

Summary

Fixes T12867. Also:

Simplify the code a little.
Stop mutating this on text/mobile -- there's no inherent value in the "youtu.be" link so I think this just changes the text the user wrote unnecessarily.

Test Plan

Screen Shot 2017-06-23 at 7.32.50 AM.png (552×1 px, 395 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 23 2017, 2:37 PM

Harbormaster completed remote builds in B17556: Diff 43668.Jun 23 2017, 2:38 PM

chad accepted this revision.Jun 23 2017, 3:10 PM

This revision is now accepted and ready to land.Jun 23 2017, 3:10 PM

Closed by commit rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2017, 3:43 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.Sep 30 2017, 10:32 PM

epriestley mentioned this in D18666: Fix an exception in the hyperlink remarkup rule for unparseable URIs.Oct 2 2017, 2:14 PM

epriestley mentioned this in rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs.Oct 2 2017, 4:10 PM

epriestley mentioned this in rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

rule/

PhabricatorYoutubeRemarkupRule.php

30 lines

Diff 43671

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

Loading...