Page MenuHomePhabricator

Fix ambiguous URI parsing in Youtube Remarkup rule
ClosedPublic

Authored by epriestley on Jun 23 2017, 2:37 PM.
Tags
None
Referenced Files
F17859602: D18149.diff
Sun, Jul 27, 8:55 PM
F17848540: D18149.diff
Sun, Jul 27, 7:31 AM
Unknown Object (File)
Jun 20 2025, 6:15 AM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:53 PM
Unknown Object (File)
Jun 16 2025, 7:59 PM
Unknown Object (File)
Jun 5 2025, 2:01 PM
Subscribers
None

Details

Summary

Fixes T12867. Also:

  • Simplify the code a little.
  • Stop mutating this on text/mobile -- there's no inherent value in the "youtu.be" link so I think this just changes the text the user wrote unnecessarily.
Test Plan

Screen Shot 2017-06-23 at 7.32.50 AM.png (552×1 px, 395 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable