Don't fatal when encountering [[ <bad URI > | ... ]]
ClosedPublic
Actions

Authored by epriestley on Jun 5 2017, 12:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]]

Commits

rPHU612619d0040b: (stable) Promote 2017 Week 23
rPHU13662252b754: (stable) Don't fatal when encountering [[ <bad URI > | ... ]]
rPHU74a1350416eb: Don't fatal when encountering [[ <bad URI > | ... ]]

Summary

Fixes T12796. In D17647, the parser became more strict, but this remarkup rule doesn't deal with it gracefully.

Instead, detect when the parse failed and bail out.

Test Plan

Put [[ http://good.com#u:p@evil.com/ | broken ]] into a Remarkup document without backticks.
Before patch: fatal ("rejecting ambiguous URI").
After patch: link doesn't work (which is correct), but page does.

Diff Detail

Repository

rPHU libphutil

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 5 2017, 12:48 PM

Harbormaster completed remote builds in B17386: Diff 43472.Jun 5 2017, 12:48 PM

epriestley mentioned this in T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .Jun 5 2017, 12:51 PM

chad accepted this revision.Jun 5 2017, 2:33 PM

This revision is now accepted and ready to land.Jun 5 2017, 2:33 PM

Closed by commit rPHU74a1350416eb: Don't fatal when encountering [[ <bad URI > | ... ]] (authored by epriestley). · Explain WhyJun 5 2017, 4:41 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.Sep 30 2017, 10:32 PM

epriestley mentioned this in D18666: Fix an exception in the hyperlink remarkup rule for unparseable URIs.Oct 2 2017, 2:14 PM

epriestley mentioned this in rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs.Oct 2 2017, 4:10 PM

epriestley mentioned this in rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

markuprule/

PhutilRemarkupDocumentLinkRule.php

13 lines

Diff 43473

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php

Don't fatal when encountering [[ <bad URI > | ... ]]ClosedPublicActions