Page MenuHomePhabricator
Differential D18666

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:14 PM.
Tags
None
Referenced Files
F13275636: D18666.diff
Fri, May 31, 5:01 AM
F13272886: D18666.id44817.diff
Thu, May 30, 11:52 PM
F13234688: D18666.diff
Tue, May 21, 3:39 AM
F13229092: D18666.id44820.diff
Mon, May 20, 2:19 PM
F13220625: D18666.diff
Sun, May 19, 1:49 AM
F13209824: D18666.id44820.diff
Fri, May 17, 2:21 AM
F13203066: D18666.diff
Tue, May 14, 11:26 PM
F13185241: D18666.diff
Sat, May 11, 2:43 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns
Commits
rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs
rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs
Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan
  • Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository
rPHU libphutil
Branch
parse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18597
Build 25050: Run Core Tests
Build 25049: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
5 lines
5 lines
remarkup/
markuprule/
15 lines

Diff 44817

View Options

src/markup/engine/__tests__/remarkup/link-with-angle-link-anchor.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-with-link-anchor.txt

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility