Page MenuHomePhabricator

Correct lint rendering when patching trailing whitespace in files
ClosedPublic

Authored by epriestley on Sep 20 2017, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:42 AM
Unknown Object (File)
Tue, Apr 23, 6:45 PM
Unknown Object (File)
Fri, Apr 5, 4:07 PM
Unknown Object (File)
Apr 4 2024, 4:57 PM
Unknown Object (File)
Mar 28 2024, 9:52 PM
Unknown Object (File)
Mar 9 2024, 4:55 AM
Unknown Object (File)
Feb 21 2024, 9:31 PM
Unknown Object (File)
Feb 10 2024, 5:36 PM
Subscribers
None

Details

Summary

Ref PHI48. If a patch removes all of the lines at the end of a file, we can get some array index errors.

Test Plan

Added failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Branch
extrawhite
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18506
Build 24924: Run Core Tests
Build 24923: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 20 2017, 7:04 PM
  • Be a little more clever so the test case does not need to have trailing whitespace itself.
  • Also, this made a lint description more concise.
This revision was automatically updated to reflect the committed changes.