Correct lint rendering when patching trailing whitespace in files
ClosedPublic
Actions

Authored by epriestley on Sep 20 2017, 7:02 PM.

Details

Reviewers

Commits

rARC19d41faddd13: (stable) Correct lint rendering when patching trailing whitespace in files
rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files

Summary

Ref PHI48. If a patch removes all of the lines at the end of a file, we can get some array index errors.

Test Plan

Added failing test, made it pass.

Diff Detail

Repository

rARC Arcanist

Branch

extrawhite

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/lint/renderer/__tests__/data/extrawhitespace.txt:2	TXT9	Trailing Whitespace at EOF

Unit

Tests Passed

Build Status

Buildable 18505
Build 24922: Run Core Tests
Build 24921: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 20 2017, 7:02 PM

Harbormaster completed remote builds in B18505: Diff 44728.Sep 20 2017, 7:03 PM

amckinley accepted this revision.Sep 20 2017, 7:04 PM

This revision is now accepted and ready to land.Sep 20 2017, 7:04 PM

Be a little more clever so the test case does not need to have trailing whitespace itself.
Also, this made a lint description more concise.

Harbormaster completed remote builds in B18506: Diff 44729.Sep 20 2017, 7:06 PM

Closed by commit rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files (authored by epriestley). · Explain WhySep 20 2017, 7:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistTextLinter.php

4 lines

renderer/

ArcanistConsoleLintRenderer.php

13 lines

__tests__/

ArcanistConsoleLintRendererTestCase.php

7 lines

data/

extrawhitespace.expect

8 lines

extrawhitespace.txt

2 lines

Diff 44728

View Options

src/lint/linter/ArcanistTextLinter.php

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/extrawhitespace.expect

View Options

src/lint/renderer/tests/data/extrawhitespace.txt

Correct lint rendering when patching trailing whitespace in filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44728

src/lint/linter/ArcanistTextLinter.php

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/extrawhitespace.expect

src/lint/renderer/__tests__/data/extrawhitespace.txt

Correct lint rendering when patching trailing whitespace in files
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/extrawhitespace.expect

src/lint/renderer/tests/data/extrawhitespace.txt