Page MenuHomePhabricator
Differential D18631

Correct lint rendering when patching trailing whitespace in files
ClosedPublic
Actions

Authored by epriestley on Sep 20 2017, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 5:06 AM
Unknown Object (File)
Thu, Jan 2, 1:45 AM
Unknown Object (File)
Tue, Dec 31, 3:22 PM
Unknown Object (File)
Sun, Dec 29, 6:38 PM
Unknown Object (File)
Fri, Dec 27, 4:27 PM
Unknown Object (File)
Thu, Dec 19, 6:51 AM
Unknown Object (File)
Mon, Dec 16, 8:06 AM
Unknown Object (File)
Dec 6 2024, 10:04 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC19d41faddd13: (stable) Correct lint rendering when patching trailing whitespace in files
rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files
Summary

Ref PHI48. If a patch removes all of the lines at the end of a file, we can get some array index errors.

Test Plan

Added failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Branch
extrawhite
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18506
Build 24924: Run Core Tests
Build 24923: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 20 2017, 7:02 PM
Harbormaster completed remote builds in B18505: Diff 44728.Sep 20 2017, 7:03 PM
amckinley accepted this revision.Sep 20 2017, 7:04 PM
This revision is now accepted and ready to land.Sep 20 2017, 7:04 PM
epriestley updated this revision to Diff 44729.Sep 20 2017, 7:05 PM
  • Be a little more clever so the test case does not need to have trailing whitespace itself.
  • Also, this made a lint description more concise.
Harbormaster completed remote builds in B18506: Diff 44729.Sep 20 2017, 7:06 PM
Closed by commit rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files (authored by epriestley). · Explain WhySep 20 2017, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44729

View Options

src/lint/linter/ArcanistTextLinter.php

Loading...
View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.expect

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.txt

Loading...
Phabricator · Built by Phacility