Page MenuHomePhabricator
Differential D18631

Correct lint rendering when patching trailing whitespace in files
ClosedPublic
Actions

Authored by epriestley on Sep 20 2017, 7:02 PM.
Tags
None
Referenced Files
F15454607: D18631.diff
Sat, Mar 29, 7:19 PM
F15397916: D18631.id44728.diff
Sun, Mar 16, 10:56 PM
F15338690: D18631.diff
Sun, Mar 9, 12:16 PM
Unknown Object (File)
Feb 9 2025, 4:44 AM
Unknown Object (File)
Feb 9 2025, 4:44 AM
Unknown Object (File)
Feb 9 2025, 4:44 AM
Unknown Object (File)
Feb 9 2025, 4:44 AM
Unknown Object (File)
Feb 9 2025, 4:44 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC19d41faddd13: (stable) Correct lint rendering when patching trailing whitespace in files
rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files
Summary

Ref PHI48. If a patch removes all of the lines at the end of a file, we can get some array index errors.

Test Plan

Added failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Branch
extrawhite
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/lint/renderer/__tests__/data/extrawhitespace.txt:2TXT9Trailing Whitespace at EOF
Unit
Tests Passed
Build Status
Buildable 18505
Build 24922: Run Core Tests
Build 24921: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 20 2017, 7:02 PM
Harbormaster completed remote builds in B18505: Diff 44728.Sep 20 2017, 7:03 PM
amckinley accepted this revision.Sep 20 2017, 7:04 PM
This revision is now accepted and ready to land.Sep 20 2017, 7:04 PM
epriestley updated this revision to Diff 44729.Sep 20 2017, 7:05 PM
  • Be a little more clever so the test case does not need to have trailing whitespace itself.
  • Also, this made a lint description more concise.
Harbormaster completed remote builds in B18506: Diff 44729.Sep 20 2017, 7:06 PM
Closed by commit rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files (authored by epriestley). · Explain WhySep 20 2017, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44728

View Options

src/lint/linter/ArcanistTextLinter.php

Loading...
View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.expect

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.txt

Loading...
Phabricator · Built by Phacility