Differential D18538

Fix a prefix/suffix counting issue in Arcanist lint rendering
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 6:50 PM.

Details

Reviewers

chad

Maniphest Tasks

T9846: Diff on `arc lint` misleading when the replacement has newlines

Commits

rARC7371277d2065: Fix a prefix/suffix counting issue in Arcanist lint rendering

Summary

Ref T9846. See PHI48. For replacing text in the form "ABC" with "ABBC", the trimmer had a bug.

Test Plan

Added failing tests, fixed 'em.

Diff Detail

Repository

rARC Arcanist

Branch

midline

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18291
Build 24613: Run Core Tests
Build 24612: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	ArcanistLintMessageTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at ArcanistLintMessageTestCase.php:70): Original text for "mid-newline". Expected: '' Actual: false
	32 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("") 7 assertions passed.
	13 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("") 3 assertions passed.
	13 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("") 4 assertions passed.
	13 ms	ArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("") 3 assertions passed.
		View Full Test Results (1 Failed · 170 Passed · 35 Skipped)

Event Timeline

epriestley created this revision.Sep 5 2017, 6:50 PM

Harbormaster failed remote builds in B18291: Diff 44509!Sep 5 2017, 6:51 PM

That build failure might be "legitimate-ish" -- maybe a version difference.

PHP 7.0.0 - If string is equal to start characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
http://php.net/substr

Thanks, PHP.