Page MenuHomePhabricator

Fix a prefix/suffix counting issue in Arcanist lint rendering
ClosedPublic

Authored by epriestley on Sep 5 2017, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 4:04 AM
Unknown Object (File)
Fri, Mar 15, 1:12 PM
Unknown Object (File)
Wed, Mar 13, 6:19 PM
Unknown Object (File)
Sat, Mar 2, 3:54 AM
Unknown Object (File)
Feb 24 2024, 2:55 PM
Unknown Object (File)
Feb 24 2024, 2:17 PM
Unknown Object (File)
Dec 25 2023, 1:47 PM
Unknown Object (File)
Dec 21 2023, 10:11 AM
Subscribers
None

Details

Summary

Ref T9846. See PHI48. For replacing text in the form "ABC" with "ABBC", the trimmer had a bug.

Test Plan

Added failing tests, fixed 'em.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

That build failure might be "legitimate-ish" -- maybe a version difference.

PHP 7.0.0 - If string is equal to start characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
http://php.net/substr

Thanks, PHP.

  • Add some casting to force PHP7 behavior?
This revision is now accepted and ready to land.Sep 5 2017, 8:04 PM
This revision was automatically updated to reflect the committed changes.