Page MenuHomePhabricator

Fix a prefix/suffix counting issue in Arcanist lint rendering
ClosedPublic

Authored by epriestley on Sep 5 2017, 6:50 PM.
Tags
None
Referenced Files
F15343529: D18538.id44510.diff
Sun, Mar 9, 11:26 PM
F15338489: D18538.diff
Sun, Mar 9, 11:03 AM
Unknown Object (File)
Sun, Feb 23, 12:15 PM
Unknown Object (File)
Thu, Feb 20, 3:10 PM
Unknown Object (File)
Feb 9 2025, 4:43 AM
Unknown Object (File)
Feb 9 2025, 4:43 AM
Unknown Object (File)
Feb 9 2025, 4:43 AM
Unknown Object (File)
Feb 9 2025, 4:43 AM
Subscribers
None

Details

Summary

Ref T9846. See PHI48. For replacing text in the form "ABC" with "ABBC", the trimmer had a bug.

Test Plan

Added failing tests, fixed 'em.

Diff Detail

Repository
rARC Arcanist
Branch
midline
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18291
Build 24613: Run Core Tests
Build 24612: arc lint + arc unit

Event Timeline

That build failure might be "legitimate-ish" -- maybe a version difference.

PHP 7.0.0 - If string is equal to start characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
http://php.net/substr

Thanks, PHP.

  • Add some casting to force PHP7 behavior?
This revision is now accepted and ready to land.Sep 5 2017, 8:04 PM
This revision was automatically updated to reflect the committed changes.