Page MenuHomePhabricator
Differential D18538

Fix a prefix/suffix counting issue in Arcanist lint rendering
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 6:50 PM.
Tags
None
Referenced Files
F14716656: D18538.diff
Fri, Jan 17, 7:01 PM
Unknown Object (File)
Tue, Jan 7, 9:33 PM
Unknown Object (File)
Mon, Dec 30, 3:35 PM
Unknown Object (File)
Mon, Dec 30, 1:42 AM
Unknown Object (File)
Fri, Dec 27, 10:45 AM
Unknown Object (File)
Fri, Dec 27, 7:16 AM
Unknown Object (File)
Fri, Dec 20, 6:36 PM
Unknown Object (File)
Dec 13 2024, 8:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC7371277d2065: Fix a prefix/suffix counting issue in Arcanist lint rendering
Summary

Ref T9846. See PHI48. For replacing text in the form "ABC" with "ABBC", the trimmer had a bug.

Test Plan

Added failing tests, fixed 'em.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 5 2017, 6:50 PM
Harbormaster failed remote builds in B18291: Diff 44509!Sep 5 2017, 6:51 PM
epriestley added a comment.Sep 5 2017, 6:53 PM

That build failure might be "legitimate-ish" -- maybe a version difference.

epriestley added a comment.Sep 5 2017, 6:55 PM

PHP 7.0.0 - If string is equal to start characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
http://php.net/substr

Thanks, PHP.

epriestley updated this revision to Diff 44510.Sep 5 2017, 6:55 PM
  • Add some casting to force PHP7 behavior?
Harbormaster completed remote builds in B18292: Diff 44510.Sep 5 2017, 6:56 PM
chad accepted this revision.Sep 5 2017, 8:04 PM
This revision is now accepted and ready to land.Sep 5 2017, 8:04 PM
Closed by commit rARC7371277d2065: Fix a prefix/suffix counting issue in Arcanist lint rendering (authored by epriestley). · Explain WhySep 5 2017, 8:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D18541: Fix a similar lint rendering issue when trimming identical lines out of patches.Sep 5 2017, 11:53 PM
epriestley mentioned this in rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches.Sep 6 2017, 12:12 AM

Revision Contents
Changeset List

PathSize
src/
lint/
14 lines
__tests__/
8 lines
renderer/
__tests__/
22 lines
data/
11 lines
4 lines

Diff 44515

View Options

src/lint/ArcanistLintMessage.php

Loading...
View Options

src/lint/__tests__/ArcanistLintMessageTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/midline.expect

Loading...
View Options

src/lint/renderer/__tests__/data/midline.txt

Loading...
Phabricator · Built by Phacility