Consolidate binary (hg, git, svn) analysis code into one place
ClosedPublic
Actions

Authored by epriestley on Jul 31 2017, 7:19 PM.

Details

Reviewers

chad
avivey

Maniphest Tasks

T12942: Add a "Binary Versions" page to Config

Commits

rPHU9c1c3ea17a49: (stable) Promote 2017 Week 31
rPHU3b087892148d: Consolidate binary (hg, git, svn) analysis code into one place

Summary

Ref T12942. Currently, we have a bunch of code spread out all over the place for doing version tests on hg, svn, and git.

Consolidate this code a bit so we can use it to drive a new section on the "Version Information" page showing the installed versions (and paths) for binaries.

The primary goal is to reduce the support burden a little bit. Two particular issues are:

Various stuff with old (or new) VCS binaries, mostly Mercurial.
Cases where the webserver sees a different binary than sudoers specifies.

These should be easier to spot with binaries in the version info.

Test Plan

Added unit tests, see also next change. Eventual result is this:

Screen Shot 2017-07-31 at 12.14.42 PM.png (341×777 px, 101 KB)

Diff Detail

Repository

rPHU libphutil

Branch

version1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/filesystem/binary/PhutilDiffBinaryAnalyzer.php:21	XHP14	Misuse of `preg_quote`

Unit

Tests Passed

Build Status

Buildable 17855
Build 23984: Run Core Tests
Build 23983: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 31 2017, 7:19 PM

Harbormaster completed remote builds in B17851: Diff 44013.Jul 31 2017, 7:20 PM

epriestley mentioned this in D18306: Move Phabricator to use PhutilBinaryAnalyzer and show binary versions.Jul 31 2017, 7:24 PM

chad accepted this revision.Jul 31 2017, 7:29 PM

This revision is now accepted and ready to land.Jul 31 2017, 7:29 PM

Also Pygmentize and nodejs?

Also, what happens if different servers in the cluster have different versions of git?

Support pygmentize.
Node is a whole separate mess, and not something we execute from the web, so skip it for now.

Harbormaster completed remote builds in B17855: Diff 44017.Jul 31 2017, 8:45 PM

😀

Also, what happens if different servers in the cluster have different versions of git?

In theory, we could enumerate every device assigned to a repository service in Almanac and query all of them for binary versions and paths to detect this. I'm inclined to wait until this actually happens before pursuing it, though.

Closed by commit rPHU3b087892148d: Consolidate binary (hg, git, svn) analysis code into one place (authored by epriestley, committed by epriestley). · Explain WhyAug 1 2017, 2:14 PM

This revision was automatically updated to reflect the committed changes.