Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types
ClosedPublic
Actions

Authored by epriestley on Jun 18 2017, 8:16 AM.

Details

Reviewers

20after4
chad
amckinley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField

Commits

rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched…

Summary

Fixes T12851.

This should fix the error I'm seeing, which is:

Argument 1 passed to array_fuse() must be of the type array, boolean given

There may be a better way to patch this up than overriding the getValue() method,
however.

Test Plan

Changed the default "Tags" filter to specify true instead of array('self'), then viewed that filter in the UI.
Before patch: fatal.
After patch: page loads. Note that true is not interpreted as array('self'), but the page isn't broken, which is a big improvement.

Diff Detail

Repository

rP Phabricator

Branch

feed1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17534
Build 23526: Run Core Tests
Build 23525: arc lint + arc unit

Event Timeline

20after4 created this revision.Jun 18 2017, 8:16 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2017, 8:16 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B17520: Diff 43628.Jun 18 2017, 8:17 AM

epriestley added a task: T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField.Jun 19 2017, 3:56 PM

After unraveling things, I have arrived at a similar but not-quite-identical patch.

Pretty much the same patch.

Harbormaster completed remote builds in B17520: Diff 43628.Jun 19 2017, 10:05 PM

Harbormaster completed remote builds in B17534: Diff 43642.

epriestley retitled this revision from Fix T12851 to Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types.Jun 19 2017, 10:06 PM

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, amckinley.

epriestley edited the summary of this revision. (Show Details)

epriestley mentioned this in T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField.Jun 23 2017, 4:22 PM

amckinley accepted this revision.Jun 23 2017, 7:13 PM

This revision is now accepted and ready to land.Jun 23 2017, 7:13 PM

Closed by commit rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched… (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2017, 7:29 PM

This revision was automatically updated to reflect the committed changes.

20after4 awarded a token.Jun 27 2017, 9:43 PM