Page MenuHomePhabricator

Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types

Authored by epriestley on Jun 18 2017, 8:16 AM.



Fixes T12851.

This should fix the error I'm seeing, which is:

  • Argument 1 passed to array_fuse() must be of the type array, boolean given

There may be a better way to patch this up than overriding the getValue() method,

Test Plan
  • Changed the default "Tags" filter to specify true instead of array('self'), then viewed that filter in the UI.
  • Before patch: fatal.
  • After patch: page loads. Note that true is not interpreted as array('self'), but the page isn't broken, which is a big improvement.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 17534
Build 23526: Run Core Tests
Build 23525: arc lint + arc unit

Event Timeline

epriestley edited reviewers, added: 20after4; removed: epriestley.
epriestley edited edge metadata.

After unraveling things, I have arrived at a similar but not-quite-identical patch.

  • Pretty much the same patch.
epriestley retitled this revision from Fix T12851 to Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types.Jun 19 2017, 10:06 PM
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, amckinley.
epriestley edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 23 2017, 7:13 PM
This revision was automatically updated to reflect the committed changes.