Page MenuHomePhabricator

Improve `ArcanistLinterStandardTestCase`
Needs ReviewPublic

Authored by wjiang on Apr 24 2017, 1:04 AM.
Tags
None
Referenced Files
F15408428: D17783.id.diff
Tue, Mar 18, 10:57 PM
F15407769: D17783.diff
Tue, Mar 18, 7:28 PM
F15399437: D17783.diff
Mon, Mar 17, 4:32 AM
F15394865: D17783.diff
Sun, Mar 16, 1:35 AM
F15376363: D17783.id42868.diff
Thu, Mar 13, 3:00 AM
F15293837: D17783.id42758.diff
Wed, Mar 5, 5:01 AM
F15293800: D17783.id42758.diff
Wed, Mar 5, 4:42 AM
F15285624: D17783.id.diff
Tue, Mar 4, 2:51 PM

Details

Summary

Ref T12631. Let unit test actually test ArcanistLinterStandard.

Test Plan

Run unit test

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D17783
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16794
Build 22413: arc lint + arc unit

Event Timeline

joshuaspence added a subscriber: joshuaspence.

LGTM. @epriestley, it would be greatly appreciated if this could be accepted upstream. We have a large number of XHPAST linter rules (I think ~200) and we want to write integration tests to ensure that they play nicely together.

src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php
4

You should extend ArcanistLinterTestCase instead

5–8

You might want to leave this.

8

Maybe call this getBaseLinter?

10

I think this should be called getStandard

15–18

Ideally, we should have some sort of $linter->applyStandard($standard) method... because this code is currently duplicated from ArcanistLinter

wjiang marked 5 inline comments as done.
  • Add applyStandard