Ref T12631. Let unit test actually test ArcanistLinterStandard.
Details
Details
- Reviewers
joshuaspence - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T12631: Improve `ArcanistLinterStandardTestCase`
Run unit test
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arcpatch-D17783
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16793 Build 22412: arc lint + arc unit
Event Timeline
Comment Actions
LGTM. @epriestley, it would be greatly appreciated if this could be accepted upstream. We have a large number of XHPAST linter rules (I think ~200) and we want to write integration tests to ensure that they play nicely together.
| src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php | ||
|---|---|---|
| 4 | You should extend ArcanistLinterTestCase instead | |
| 5–8 | You might want to leave this. | |
| 8 | Maybe call this getBaseLinter? | |
| 10 | I think this should be called getStandard | |
| 15–18 | Ideally, we should have some sort of $linter->applyStandard($standard) method... because this code is currently duplicated from ArcanistLinter | |