Page MenuHomePhabricator

Improve `ArcanistLinterStandardTestCase`
Needs ReviewPublic

Authored by wjiang on Apr 24 2017, 1:04 AM.

Details

Summary

Ref T12631. Let unit test actually test ArcanistLinterStandard.

Test Plan

Run unit test

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16685
Build 22254: arc lint + arc unit

Event Timeline

joshuaspence added a subscriber: joshuaspence.

LGTM. @epriestley, it would be greatly appreciated if this could be accepted upstream. We have a large number of XHPAST linter rules (I think ~200) and we want to write integration tests to ensure that they play nicely together.

src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php
4

You should extend ArcanistLinterTestCase instead

5–8

You might want to leave this.

6–18

Maybe call this getBaseLinter?

8

I think this should be called getStandard

13–16

Ideally, we should have some sort of $linter->applyStandard($standard) method... because this code is currently duplicated from ArcanistLinter

wjiang marked 5 inline comments as done.
  • Add applyStandard