Ref T4334. Adds support for [[http://php.net/manual/en/migration56.new-features.php#migration56.new-features.exponentiation | exponentiation via **]] to XHPAST.
Details
Details
- Reviewers
epriestley richardvanvelzen - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4334: Support PHP5.4+ syntax in XHPAST
Added a test case.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 16771 Build 22375: Run Core Tests Build 22374: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 44 ms | PHPASTParserTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:120): Parser output for "base-pass.php.test".
Expected vs Actual Output Diff
--- Old Value
| |
| 22 ms | PHPASTParserTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:120): Parser output for "base-pass.php.test".
Expected vs Actual Output Diff
--- Old Value
| |
| 1 ms | AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed. | |
| 0 ms | AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed. | |
| 0 ms | AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed. | |
| View Full Test Results (2 Failed · 383 Passed · 2 Skipped) |
Event Timeline
Comment Actions
I definitely did something wrong here, because I updated src/parser/xhpast/parser_tokens.php by hand...
Comment Actions
Because the token values have shifted pretty much all test cases have bad data :(
It will probably be a lot easier to handle after something like D17802#214972 is implemented.
Comment Actions
wow exactly what the language desperately needed
I bet there are as many as 0 uses for this in our small million-line codebase