Make the query compiler emit intermediate tokens
ClosedPublic
Actions

Authored by epriestley on Apr 12 2017, 10:43 PM.

Details

Reviewers

Maniphest Tasks

T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it
T7860: When users search for "#x y", treat "#x" as a project hashtag
T12003: Explain to users how fulltext queries are parsed and executed
T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token

Commits

rPHU7c7b02216f33: (stable) Promote 2017 Week 15
rPHU6fe33623cda6: Make the query compiler emit intermediate tokens

Summary

Ref T12137. Ref T12003. Ref T2632. Ref T7860. In all these tasks, we want to examine or interact with the query after it is parsed, but before it is compiled.

Make the compiler emit an intermediate parsed representation so we can do that.

(The next change fixes Phabricator for this new API.)

Test Plan

Ran unit tests, see also next change.

Diff Detail

Repository

rPHU libphutil

Branch

search2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16424
Build 21853: Run Core Tests
Build 21852: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2017, 10:43 PM

Harbormaster completed remote builds in B16424: Diff 42493.Apr 12 2017, 10:43 PM

epriestley added a child revision: D17670: Update Phabricator to use intermediate tokens from the query compiler.Apr 12 2017, 10:44 PM

chad accepted this revision.Apr 13 2017, 1:20 AM

This revision is now accepted and ready to land.Apr 13 2017, 1:20 AM

Closed by commit rPHU6fe33623cda6: Make the query compiler emit intermediate tokens (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2017, 2:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

search/

PhutilSearchQueryCompiler.php

46 lines

PhutilSearchQueryToken.php

31 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

11 lines

Diff 42493

View Options

src/__phutil_library_map__.php

View Options

src/search/PhutilSearchQueryCompiler.php

View Options

src/search/PhutilSearchQueryToken.php

View Options

src/search/tests/PhutilSearchQueryCompilerTestCase.php

Make the query compiler emit intermediate tokensClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42493

src/__phutil_library_map__.php

src/search/PhutilSearchQueryCompiler.php

src/search/PhutilSearchQueryToken.php

src/search/__tests__/PhutilSearchQueryCompilerTestCase.php

Make the query compiler emit intermediate tokens
ClosedPublic
Actions

Revision Contents
Changeset List

src/search/tests/PhutilSearchQueryCompilerTestCase.php