Page MenuHomePhabricator

Show users how fulltext search queries are parsed and executed; don't query stopwords or short tokens
ClosedPublic

Authored by epriestley on Apr 13 2017, 12:04 AM.

Details

Summary

Depends on D17670. Fixes T12137. Fixes T12003. Ref T2632.

This shows users a readout of which terms were actually searched for.

This also drops those terms from the query we submit to the backend, dodging the weird behaviors / search engine bugs in T12137.

This might need some design tweaking.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • Use phutil_utf8_strlen() for identifying short tokens.

InnoDB list is pretty conservative:

https://dev.mysql.com/doc/refman/5.7/en/fulltext-stopwords.html

| a     |
| about |
| an    |
| are   |
| as    |
| at    |
| be    |
| by    |
| com   |
| de    |
| en    |
| for   |
| from  |
| how   |
| i     |
| in    |
| is    |
| it    |
| la    |
| of    |
| on    |
| or    |
| that  |
| the   |
| this  |
| to    |
| was   |
| what  |
| when  |
| where |
| who   |
| will  |
| with  |
| und   |
| the   |
| www   |
This revision is now accepted and ready to land.Apr 13 2017, 1:59 AM
This revision was automatically updated to reflect the committed changes.