Page MenuHomePhabricator
Differential D17670

Update Phabricator to use intermediate tokens from the query compiler
ClosedPublic
Actions

Authored by epriestley on Apr 12 2017, 10:44 PM.
Tags
None
Referenced Files
F19467992: D17670.diff
Sat, Jan 3, 9:14 PM
F19303138: D17670.diff
Tue, Dec 23, 6:35 PM
F19091324: D17670.id42494.diff
Dec 3 2025, 2:22 PM
F19084747: D17670.id.diff
Dec 2 2025, 4:06 PM
F19079283: D17670.diff
Dec 1 2025, 8:44 PM
F19057878: D17670.id.diff
Nov 29 2025, 12:12 AM
F19055641: D17670.id42494.diff
Nov 28 2025, 5:50 PM
F19055065: D17670.diff
Nov 28 2025, 3:44 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it
T7860: When users search for "#x y", treat "#x" as a project hashtag
T12003: Explain to users how fulltext queries are parsed and executed
T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token
Commits
rPcb49acc2ca71: Update Phabricator to use intermediate tokens from the query compiler
Summary

Depends on D17669. Ref T12137. Ref T12003. Ref T2632. Ref T7860.

Converts Phabricator to the new parse + compile workflow with intermediate tokens.

Also fixes a bug where searches for cat" or similar (unmatched quotes) wouldn't produce a nice exception.

Test Plan
  • Fulltext searched.
  • Fulltext searched in Conpherence.
  • Fulltext searched with bad syntax.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
query/
6 lines
search/
fulltextstorage/
7 lines
infrastructure/
cluster/
search/
4 lines

Diff 42502

View Options

src/applications/conpherence/query/ConpherenceFulltextQuery.php

Loading...
View Options

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

Loading...
View Options

src/infrastructure/cluster/search/PhabricatorSearchService.php

Loading...
Phabricator · Built by Phacility