Paths

Table of Contentst

Update Phabricator to use intermediate tokens from the query compiler
ClosedPublic
Actions

Authored by epriestley on Apr 12 2017, 10:44 PM.

Details

Reviewers

Maniphest Tasks

T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it
T7860: When users search for "#x y", treat "#x" as a project hashtag
T12003: Explain to users how fulltext queries are parsed and executed
T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token

Commits

rPcb49acc2ca71: Update Phabricator to use intermediate tokens from the query compiler

Summary

Depends on D17669. Ref T12137. Ref T12003. Ref T2632. Ref T7860.

Converts Phabricator to the new parse + compile workflow with intermediate tokens.

Also fixes a bug where searches for cat" or similar (unmatched quotes) wouldn't produce a nice exception.

Test Plan

Fulltext searched.
Fulltext searched in Conpherence.
Fulltext searched with bad syntax.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2017, 10:44 PM

Harbormaster completed remote builds in B16425: Diff 42494.Apr 12 2017, 10:45 PM

epriestley added a child revision: D17672: Show users how fulltext search queries are parsed and executed; don't query stopwords or short tokens.Apr 13 2017, 12:04 AM

chad accepted this revision.Apr 13 2017, 1:22 AM

This revision is now accepted and ready to land.Apr 13 2017, 1:22 AM

Closed by commit rPcb49acc2ca71: Update Phabricator to use intermediate tokens from the query compiler (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2017, 2:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceFulltextQuery.php

6 lines

search/

fulltextstorage/

PhabricatorMySQLFulltextStorageEngine.php

7 lines

infrastructure/

cluster/

search/

PhabricatorSearchService.php

4 lines

Diff 42502

View Options

src/applications/conpherence/query/ConpherenceFulltextQuery.php

View Options

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

View Options

src/infrastructure/cluster/search/PhabricatorSearchService.php

Update Phabricator to use intermediate tokens from the query compilerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42502

src/applications/conpherence/query/ConpherenceFulltextQuery.php

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

src/infrastructure/cluster/search/PhabricatorSearchService.php

Update Phabricator to use intermediate tokens from the query compiler
ClosedPublic
Actions

Revision Contents
Changeset List