Page MenuHomePhabricator
Differential D17670

Update Phabricator to use intermediate tokens from the query compiler
ClosedPublic
Actions

Authored by epriestley on Apr 12 2017, 10:44 PM.
Tags
None
Referenced Files
F15187944: D17670.diff
Fri, Feb 21, 12:09 PM
Unknown Object (File)
Thu, Feb 20, 8:41 AM
Unknown Object (File)
Fri, Feb 14, 8:00 PM
Unknown Object (File)
Wed, Feb 12, 4:11 AM
Unknown Object (File)
Sat, Feb 8, 4:55 PM
Unknown Object (File)
Tue, Feb 4, 3:25 AM
Unknown Object (File)
Thu, Jan 30, 11:41 PM
Unknown Object (File)
Thu, Jan 30, 1:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it
T7860: When users search for "#x y", treat "#x" as a project hashtag
T12003: Explain to users how fulltext queries are parsed and executed
T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token
Commits
rPcb49acc2ca71: Update Phabricator to use intermediate tokens from the query compiler
Summary

Depends on D17669. Ref T12137. Ref T12003. Ref T2632. Ref T7860.

Converts Phabricator to the new parse + compile workflow with intermediate tokens.

Also fixes a bug where searches for cat" or similar (unmatched quotes) wouldn't produce a nice exception.

Test Plan
  • Fulltext searched.
  • Fulltext searched in Conpherence.
  • Fulltext searched with bad syntax.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
query/
6 lines
search/
fulltextstorage/
7 lines
infrastructure/
cluster/
search/
4 lines

Diff 42502

View Options

src/applications/conpherence/query/ConpherenceFulltextQuery.php

Loading...
View Options

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

Loading...
View Options

src/infrastructure/cluster/search/PhabricatorSearchService.php

Loading...
Phabricator · Built by Phacility