Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 9:07 PM
Unknown Object (File)
Tue, Dec 31, 6:47 PM
Unknown Object (File)
Dec 14 2024, 1:01 AM
Unknown Object (File)
Dec 9 2024, 12:45 PM
Unknown Object (File)
Dec 9 2024, 12:45 PM
Unknown Object (File)
Dec 9 2024, 12:45 PM
Unknown Object (File)
Dec 5 2024, 11:21 AM
Unknown Object (File)
Dec 5 2024, 7:58 AM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable