Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
F14119450: D17558.diff
Fri, Nov 29, 5:13 AM
Unknown Object (File)
Tue, Nov 26, 7:51 PM
Unknown Object (File)
Sat, Nov 23, 5:15 AM
Unknown Object (File)
Fri, Nov 22, 12:31 PM
Unknown Object (File)
Sun, Nov 17, 9:09 PM
Unknown Object (File)
Thu, Nov 14, 3:35 AM
Unknown Object (File)
Sun, Nov 10, 11:08 AM
Unknown Object (File)
Wed, Nov 6, 5:01 AM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Branch
resign1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16138
Build 21418: Run Core Tests
Build 21417: arc lint + arc unit