Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 11:10 AM
Unknown Object (File)
Wed, Mar 27, 6:32 AM
Unknown Object (File)
Jan 26 2024, 11:35 PM
Unknown Object (File)
Jan 3 2024, 7:24 PM
Unknown Object (File)
Dec 30 2023, 6:03 PM
Unknown Object (File)
Dec 27 2023, 3:49 AM
Unknown Object (File)
Dec 26 2023, 7:28 PM
Unknown Object (File)
Dec 23 2023, 1:50 PM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable