Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
F19303842: D17558.diff
Wed, Dec 24, 5:55 AM
F18851585: D17558.id42226.diff
Oct 31 2025, 2:21 AM
F18757173: D17558.id42226.diff
Oct 5 2025, 3:54 PM
F18733530: D17558.id.diff
Sep 30 2025, 10:36 PM
F18628622: D17558.diff
Sep 16 2025, 6:44 AM
F18508670: D17558.id.diff
Sep 5 2025, 2:57 AM
F18500757: D17558.diff
Sep 4 2025, 9:18 PM
F18430719: D17558.diff
Aug 31 2025, 4:21 AM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Branch
resign1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16138
Build 21418: Run Core Tests
Build 21417: arc lint + arc unit