Page MenuHomePhabricator

Don't allow forms which can't create objects to be added to profile menus
ClosedPublic

Authored by epriestley on Feb 16 2017, 11:17 PM.
Tags
None
Referenced Files
F15413907: D17372.id.diff
Wed, Mar 19, 9:57 PM
F15400087: D17372.id41773.diff
Mon, Mar 17, 9:37 AM
Unknown Object (File)
Sun, Mar 2, 9:44 AM
Unknown Object (File)
Fri, Feb 28, 5:43 AM
Unknown Object (File)
Feb 8 2025, 8:00 AM
Unknown Object (File)
Jan 23 2025, 8:47 PM
Unknown Object (File)
Jan 23 2025, 8:47 PM
Unknown Object (File)
Jan 23 2025, 8:47 PM
Subscribers
None

Details

Summary

Fixes T12281. Some forms (like Settings) can't actually create new objects. Currently, though, you can select them and add them to profile menus; if you do, they fail when building an item.

Kick them out of the typeahead, and decline to render them in menus.

Test Plan

Added "Create Settings" to a menu, no longer fatals after patch (item vanished from menu, still editable normally to get rid of it).

Tried to add another "Create Settings", no longer available in typehaead.

Added some normal stuff.

Viewed a choose-among-forms dropdown in Maniphest, which still worked normally.

Diff Detail

Repository
rP Phabricator
Branch
edit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15669
Build 20693: Run Core Tests
Build 20692: arc lint + arc unit