Page MenuHomePhabricator
Create Task
Maniphest T12281

Exception thrown when adding a form to the Favorites menu
Closed, ResolvedPublic
Actions

Description

Hi, one of our users in our Phabricator instance faced a very nasty bug that completely prevented them from using the website when logged in.

Our instance is up-to-date on the stable channel.

phabricator
    c3bdcb4ca85487921909f0202aa760e8ed61404a (Sun, Feb 5) (branched from 9c62a10989e03e518f855de3fc0a610543287c71 on origin)

I could reproduce the issue with my account. I could also reproduce the issue on a Phacility Test Instance.
Steps:

  • In the Favorites menu next to the search bar,
  • Open "Edit Favorites"
  • Add a new "Form" menu item
  • Type the "Create Settings" form name
  • Confirm. The whole Phabricator instance should now throw the following exception for the user:
PhutilMethodNotImplementedException
Method getEditorURI in class PhabricatorSettingsEditEngine is not implemented!

The only way I found to fix the issue was to disable the culprit menu item directly, manually, inside the database (the table is {$NAMESPACE}_search/search_profilepanelconfiguration if anyone needs it before the bug is fixed).

Revisions and Commits

rP Phabricator
D17372rPb2739710ba74 Don't allow forms which can't create objects to be added to profile menus

Related Objects

Event Timeline

Itms created this task.Feb 16 2017, 9:50 PM
Itms updated the task description. (Show Details)Feb 16 2017, 9:57 PM
epriestley added a revision: D17372: Don't allow forms which can't create objects to be added to profile menus.Feb 16 2017, 11:17 PM
epriestley added a subscriber: epriestley.Feb 16 2017, 11:19 PM

Thanks! Your reproduction instructions were extremely clear and made hunting this down straightforward. D17372 should resolve this.

Manual surgery in the database (like you describe) is probably the only way to fix this until that lands.

epriestley closed this task as Resolved by committing rPb2739710ba74: Don't allow forms which can't create objects to be added to profile menus.Feb 16 2017, 11:45 PM
epriestley added a commit: rPb2739710ba74: Don't allow forms which can't create objects to be added to profile menus.
Phabricator · Built by Phacility