Page MenuHomePhabricator
Files F15413907

D17372.id.diff
No OneTemporary
Actions

D17372.id.diff
View Options

diff --git a/src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php
--- a/src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php
@@ -106,12 +106,14 @@
if (!$form) {
return array();
}
- $engine = $form->getEngine();
- $form_key = $form->getIdentifier();
$icon = $form->getIcon();
$name = $this->getDisplayName($config);
- $href = $engine->getEditURI(null, "form/{$form_key}/");
+
+ $href = $form->getCreateURI();
+ if ($href === null) {
+ return array();
+ }
$item = $this->newItem()
->setHref($href)
diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -1489,8 +1489,7 @@
);
} else {
foreach ($configs as $config) {
- $form_key = $config->getIdentifier();
- $config_uri = $this->getEditURI(null, "form/{$form_key}/");
+ $config_uri = $config->getCreateURI();
if ($parameters) {
$config_uri = (string)id(new PhutilURI($config_uri))
diff --git a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
--- a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
+++ b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
@@ -216,6 +216,19 @@
return "/transactions/editengine/{$engine_key}/view/{$key}/";
}
+ public function getCreateURI() {
+ $form_key = $this->getIdentifier();
+ $engine = $this->getEngine();
+
+ try {
+ $create_uri = $engine->getEditURI(null, "form/{$form_key}/");
+ } catch (Exception $ex) {
+ $create_uri = null;
+ }
+
+ return $create_uri;
+ }
+
public function getIdentifier() {
$key = $this->getID();
if (!$key) {
diff --git a/src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php b/src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php
--- a/src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php
+++ b/src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php
@@ -30,11 +30,17 @@
$forms = $this->executeQuery($query);
$results = array();
foreach ($forms as $form) {
+ $create_uri = $form->getCreateURI();
+ if (!$create_uri) {
+ continue;
+ }
+
if ($form->getID()) {
$key = $form->getEngineKey().'/'.$form->getID();
} else {
$key = $form->getEngineKey().'/'.$form->getBuiltinKey();
}
+
$result = id(new PhabricatorTypeaheadResult())
->setName($form->getName())
->setPHID($key)

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 9:57 PM (2 h, 49 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709609
Default Alt Text
D17372.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility