See D14617. This could probably go either way but we don't currently need $engine in newStandardEditField(), so just get rid of it.
Details
Details
Edited a task with standard custom fields defined.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- stan2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15664 Build 20685: Run Core Tests Build 20684: arc lint + arc unit
Event Timeline
| src/infrastructure/customfield/field/PhabricatorCustomField.php | ||
|---|---|---|
| 1097 | Perhaps remove the parameter too, it's now unused. | |
Comment Actions
I think subclasses might reasonably want to override this method and need access to $engine to do so. This is theoretical in the upstream, but PhabricatorCustomField is extensible by third-party code, and we have some (non-custom) fields in first-party applications where behavior depends on $editor (for example, fields which only appear on either the "create" or "edit" screen, but not both).