Page MenuHomePhabricator

Remove extra parameter in newStandardEditField() call
ClosedPublic

Authored by epriestley on Feb 16 2017, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 4:56 AM
Unknown Object (File)
Tue, Mar 12, 12:45 PM
Unknown Object (File)
Feb 16 2024, 2:15 PM
Unknown Object (File)
Jan 25 2024, 3:19 AM
Unknown Object (File)
Jan 24 2024, 11:55 PM
Unknown Object (File)
Jan 15 2024, 5:28 AM
Unknown Object (File)
Dec 27 2023, 9:53 AM
Unknown Object (File)
Dec 27 2023, 9:53 AM
Subscribers
None

Details

Summary

See D14617. This could probably go either way but we don't currently need $engine in newStandardEditField(), so just get rid of it.

Test Plan

Edited a task with standard custom fields defined.

Diff Detail

Repository
rP Phabricator
Branch
stan2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15664
Build 20685: Run Core Tests
Build 20684: arc lint + arc unit

Event Timeline

src/infrastructure/customfield/field/PhabricatorCustomField.php
1097

Perhaps remove the parameter too, it's now unused.

I think subclasses might reasonably want to override this method and need access to $engine to do so. This is theoretical in the upstream, but PhabricatorCustomField is extensible by third-party code, and we have some (non-custom) fields in first-party applications where behavior depends on $editor (for example, fields which only appear on either the "create" or "edit" screen, but not both).

This revision is now accepted and ready to land.Feb 16 2017, 4:50 PM
This revision was automatically updated to reflect the committed changes.