HomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode

Description

Fix a CalendarExport issue when an existing export has an unsupported mode

Summary:
See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan:
Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Reviewers: vrana, chad

Reviewed By: vrana

Differential Revision: https://secure.phabricator.com/D17369

Details

Provenance
epriestleyAuthored on Feb 16 2017, 2:18 PM
epriestleyPushed on Feb 16 2017, 2:22 PM
Reviewer
vrana
Differential Revision
D17369: Fix a CalendarExport issue when an existing export has an unsupported mode
Parents
rPe0cd3062d5ab: Restrict all crumbs to 240 max width
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15663
Build 20683: Run Core Tests