Page MenuHomePhabricator

Partially support CustomFields in EditEngine
ClosedPublic

Authored by epriestley on Nov 30 2015, 10:25 PM.
Tags
None
Referenced Files
F14011752: D14617.diff
Fri, Nov 1, 5:12 AM
F14007822: D14617.diff
Tue, Oct 29, 11:56 AM
F14007280: D14617.id.diff
Tue, Oct 29, 2:57 AM
F13991602: D14617.diff
Tue, Oct 22, 11:45 AM
F13971667: D14617.diff
Oct 17 2024, 2:38 PM
F13962005: D14617.id35401.diff
Oct 15 2024, 7:32 AM
Unknown Object (File)
Oct 8 2024, 1:51 AM
Unknown Object (File)
Sep 12 2024, 8:14 AM
Subscribers

Details

Summary

Ref T9132. This isn't perfect, but doesn't break any existing functionality. This stuff works:

  • Editing values.
  • Reordering fields.
  • All builtin field tyepes.

This stuff may not work yet:

  • Assigning custom field defaults.
  • Some conduit stuff.
  • Fully custom fields?
  • Locking/hiding fields? Didn't actually test this one.

I'll keep chipping away at that stuff. In some cases, it may be easier to convert all the CustomField apps first, although Differential might be a fair bit of work.

Test Plan

Created a bunch of custom fields of every avialable type and edited them.

Screen Shot 2015-11-30 at 2.21.41 PM.png (1×1 px, 189 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Partially support CustomFields in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2015, 12:39 AM
epriestley edited edge metadata.
  • Don't show misleading parameters in parameter prefilling view.
  • Don't show misleading parameters in Conduit.
  • Fix an issue with "Required" fields.
This revision was automatically updated to reflect the committed changes.
vrana added inline comments.
src/infrastructure/customfield/field/PhabricatorCustomField.php
1086

newStandardEditField doesn't accept any parameters.