Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 1:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:11 AM
Unknown Object (File)
Fri, Apr 19, 6:14 PM
Unknown Object (File)
Mon, Apr 1, 4:33 PM
Unknown Object (File)
Mon, Apr 1, 3:02 AM
Unknown Object (File)
Sat, Mar 30, 4:09 AM
Unknown Object (File)
Thu, Mar 28, 4:26 PM
Unknown Object (File)
Mar 21 2024, 12:49 PM
Unknown Object (File)
Feb 24 2024, 4:40 PM
Subscribers

Details

Test Plan

Ran phpstan analyze -a autoload.php arcanist/src with autoload.php containing:

<?php
require_once 'libphutil/src/__phutil_library_init__.php';
require_once 'arcanist/src/__phutil_library_init__.php';

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 15658
Build 20676: Run Core Tests
Build 20675: arc lint + arc unit

Unit TestsFailed

TimeTest
432 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
35 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
14 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
14 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
4 assertions passed.
14 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 189 Passed · 66 Skipped)

Event Timeline

The test error seems to be caused by a different version of JSHint (I have 2.3.0).

This revision is now accepted and ready to land.Feb 16 2017, 1:43 PM
This revision was automatically updated to reflect the committed changes.