Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 1:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 1:59 AM
Unknown Object (File)
Fri, May 30, 3:52 AM
Unknown Object (File)
Thu, May 29, 9:04 AM
Unknown Object (File)
Wed, May 28, 9:33 AM
Unknown Object (File)
May 27 2025, 11:31 AM
Unknown Object (File)
May 8 2025, 3:48 AM
Unknown Object (File)
Apr 29 2025, 1:52 PM
Unknown Object (File)
Apr 28 2025, 3:45 AM
Subscribers

Details

Test Plan

Ran phpstan analyze -a autoload.php arcanist/src with autoload.php containing:

<?php
require_once 'libphutil/src/__phutil_library_init__.php';
require_once 'arcanist/src/__phutil_library_init__.php';

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 15657
Build 20674: Run Core Tests
Build 20673: arc lint + arc unit

Unit TestsFailed

TimeTest
481 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
31 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
13 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
13 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
4 assertions passed.
13 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 189 Passed · 66 Skipped)

Event Timeline

The test error seems to be caused by a different version of JSHint (I have 2.3.0).

This revision is now accepted and ready to land.Feb 16 2017, 1:43 PM
This revision was automatically updated to reflect the committed changes.