Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 1:23 PM.
Tags
None
Referenced Files
F15415807: D17367.id41761.diff
Thu, Mar 20, 7:55 AM
F15409781: D17367.diff
Wed, Mar 19, 5:15 AM
F15393464: D17367.id41761.diff
Sat, Mar 15, 9:00 PM
F15392657: D17367.diff
Sat, Mar 15, 4:40 PM
F15379270: D17367.id41761.diff
Thu, Mar 13, 7:54 PM
F15341190: D17367.id41761.diff
Sun, Mar 9, 7:01 PM
F15283041: D17367.id.diff
Tue, Mar 4, 4:48 AM
Unknown Object (File)
Sat, Mar 1, 7:44 PM
Subscribers

Details

Test Plan

Ran phpstan analyze -a autoload.php arcanist/src with autoload.php containing:

<?php
require_once 'libphutil/src/__phutil_library_init__.php';
require_once 'arcanist/src/__phutil_library_init__.php';

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The test error seems to be caused by a different version of JSHint (I have 2.3.0).

This revision is now accepted and ready to land.Feb 16 2017, 1:43 PM
This revision was automatically updated to reflect the committed changes.