Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 1:23 PM.
Tags
None
Referenced Files
F14960426: D17367.id41762.diff
Sun, Feb 16, 5:45 AM
F14958367: D17367.id.diff
Sun, Feb 16, 4:12 AM
F14958242: D17367.id41765.diff
Sun, Feb 16, 4:07 AM
F14955488: D17367.id41765.diff
Sun, Feb 16, 1:19 AM
F14955056: D17367.id.diff
Sun, Feb 16, 1:05 AM
F14955039: D17367.id41762.diff
Sun, Feb 16, 1:04 AM
Unknown Object (File)
Sat, Feb 15, 9:48 PM
Unknown Object (File)
Tue, Feb 11, 4:54 AM
Subscribers

Details

Test Plan

Ran phpstan analyze -a autoload.php arcanist/src with autoload.php containing:

<?php
require_once 'libphutil/src/__phutil_library_init__.php';
require_once 'arcanist/src/__phutil_library_init__.php';

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The test error seems to be caused by a different version of JSHint (I have 2.3.0).

This revision is now accepted and ready to land.Feb 16 2017, 1:43 PM
This revision was automatically updated to reflect the committed changes.