Page MenuHomePhabricator

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
F15408728: D17298.id41605.diff
Wed, Mar 19, 12:55 AM
F15403116: D17298.id41617.diff
Tue, Mar 18, 1:57 AM
F15386254: D17298.diff
Sat, Mar 15, 12:14 AM
F15383878: D17298.id.diff
Fri, Mar 14, 6:14 PM
F15377305: D17298.id41617.diff
Thu, Mar 13, 8:34 AM
F15333451: D17298.id41617.diff
Sat, Mar 8, 2:23 AM
Unknown Object (File)
Sat, Mar 1, 9:36 PM
Unknown Object (File)
Feb 18 2025, 2:16 AM
Subscribers
None

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Branch
pin1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15503
Build 20438: Run Core Tests
Build 20437: arc lint + arc unit