Page MenuHomePhabricator

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
F15626154: D17298.id41617.diff
Sun, May 18, 2:24 PM
Unknown Object (File)
Sat, May 10, 2:42 AM
Unknown Object (File)
Sat, May 10, 12:01 AM
Unknown Object (File)
Apr 5 2025, 3:43 PM
Unknown Object (File)
Apr 5 2025, 2:17 AM
Unknown Object (File)
Apr 4 2025, 7:03 PM
Unknown Object (File)
Mar 31 2025, 12:27 PM
Unknown Object (File)
Mar 31 2025, 8:33 AM
Subscribers
None

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Branch
pin1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15503
Build 20438: Run Core Tests
Build 20437: arc lint + arc unit