HomePhabricator

Remove menu item pinning from Home and Favorites profile menus

Description

Remove menu item pinning from Home and Favorites profile menus

Summary:
Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.

Test Plan:

  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17298

Details

Provenance
epriestleyAuthored on Feb 2 2017, 3:37 PM
epriestleyPushed on Feb 3 2017, 1:37 PM
Reviewer
chad
Differential Revision
D17298: Remove menu item pinning from Home and Favorites profile menus
Parents
rPc0e357345412: Break long words on txt files in Diffusion
Branches
Unknown
Tags
Unknown
Tasks
T12174: Home Menu Errata
Build Status
Buildable 15514
Build 20456: Run Core Tests