Page MenuHomePhabricator

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
F18946439: D17298.diff
Tue, Nov 11, 8:16 PM
F18818238: D17298.id.diff
Tue, Oct 21, 10:26 PM
F18809726: D17298.id41605.diff
Sun, Oct 19, 4:24 PM
F18779348: D17298.diff
Oct 11 2025, 1:34 PM
F18626974: D17298.diff
Sep 16 2025, 2:54 AM
F18101371: D17298.id41617.diff
Aug 9 2025, 12:37 PM
F18094321: D17298.id.diff
Aug 7 2025, 10:04 PM
F18051462: D17298.id41605.diff
Aug 3 2025, 11:23 PM
Subscribers
None

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable