Page MenuHomePhabricator

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 5:02 PM
Unknown Object (File)
Mon, Mar 4, 12:01 AM
Unknown Object (File)
Mon, Mar 4, 12:01 AM
Unknown Object (File)
Mon, Mar 4, 12:01 AM
Unknown Object (File)
Feb 25 2024, 2:27 PM
Unknown Object (File)
Feb 8 2024, 6:17 PM
Unknown Object (File)
Feb 3 2024, 2:26 PM
Unknown Object (File)
Jan 26 2024, 3:34 AM
Subscribers
None

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Branch
pin1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15503
Build 20438: Run Core Tests
Build 20437: arc lint + arc unit