Page MenuHomePhabricator

Excluded authored commits from "Ready to Audit"; handle unreachable commits better
ClosedPublic

Authored by epriestley on Jan 31 2017, 9:19 PM.
Tags
None
Referenced Files
F13210314: D17279.id41571.diff
Fri, May 17, 4:42 AM
F13208603: D17279.diff
Thu, May 16, 6:06 PM
F13202898: D17279.diff
Tue, May 14, 11:17 PM
F13181314: D17279.id41567.diff
Thu, May 9, 11:37 AM
Unknown Object (File)
Sat, May 4, 6:53 PM
Unknown Object (File)
Wed, May 1, 2:18 AM
Unknown Object (File)
Wed, May 1, 12:20 AM
Unknown Object (File)
Mon, Apr 29, 5:36 PM
Subscribers
None

Details

Summary

Ref T10978. I'm inching toward cleaning up our audit state. Two issues are:

  • Authored commits show up in "Ready to Audit", but should not.
  • Unreachable commits (like that stacked of unsquashed stuff) show up too, but we don't really care about them.

Kick authored stuff out of the "Ready to Audit" bucket and hide unreachable commits by default, with constraints for filtering. Also give them a closed/disabled/strikethru style.

Test Plan
  • Viewed audit buckets.
  • Searched for reachable/unreachable commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable