Page MenuHomePhabricator

Excluded authored commits from "Ready to Audit"; handle unreachable commits better
ClosedPublic

Authored by epriestley on Jan 31 2017, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 10:30 AM
Unknown Object (File)
Feb 3 2024, 2:21 PM
Unknown Object (File)
Jan 23 2024, 11:30 PM
Unknown Object (File)
Dec 27 2023, 9:39 AM
Unknown Object (File)
Dec 27 2023, 9:39 AM
Unknown Object (File)
Dec 27 2023, 9:39 AM
Unknown Object (File)
Dec 21 2023, 4:06 PM
Unknown Object (File)
Dec 21 2023, 4:06 PM
Subscribers
None

Details

Summary

Ref T10978. I'm inching toward cleaning up our audit state. Two issues are:

  • Authored commits show up in "Ready to Audit", but should not.
  • Unreachable commits (like that stacked of unsquashed stuff) show up too, but we don't really care about them.

Kick authored stuff out of the "Ready to Audit" bucket and hide unreachable commits by default, with constraints for filtering. Also give them a closed/disabled/strikethru style.

Test Plan
  • Viewed audit buckets.
  • Searched for reachable/unreachable commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable